lkml.org 
[lkml]   [2009]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] basic perf support for sparc
From
From: Ingo Molnar <mingo@elte.hu>
Date: Fri, 4 Sep 2009 07:02:56 +0200

>
> * David Miller <davem@davemloft.net> wrote:
>
>> Does this build for you without adding an
>> arch/sparc/include/asm/perf_counter.h that looks
>> something like the following?
>>
>> #ifndef _ASM_SPARC_PERF_COUNTER_H
>> #define _ASM_SPARC_PERF_COUNTER_H
>>
>> #define PERF_COUNTER_INDEX_OFFSET 0
>>
>> #endif
>>
>> Or is this somehow now required in the -tip trees?
>
> This used to be required but i recently fixed this (and that fix is
> upstream as well) via:
>
> f738eb1: perf_counter: Fix the PARISC build
>
> there's now a default define of 0 so you dont have to define it and
> can leave out this chunk.
>
> ( That index is only interesting if the architecture has a way to
> allow unprivileged user-space to access counter registers
> directly. In that case the index reflects the offset from the
> (constantly changing) dynamix index which we put into the mmap
> header. With Sparc not having a hw-PMU implementation this index
> is entirely uninteresting at this stage. )

But you still do need at least an empty perf_counter.h file
right? Jens must have left the file out of his submission
by accident, and that's what I'm trying to get to the bottom
of here :-)

I assume there was a similar change to deal with references to
set_perf_counter_pending() too or is at least a NOP definition
still needed?


\
 
 \ /
  Last update: 2009-09-04 07:11    [W:0.114 / U:1.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site