Messages in this thread | | | Date | Wed, 30 Sep 2009 16:27:42 +0800 | Subject | Re: [2.6.31-git17] WARNING: at kernel/hrtimer.c:648 hres_timers_resume+0x40/0x50()/WARNING: at drivers/base/sys.c:353 __sysdev_resume+0xc3/0xe0() | From | Yong Zhang <> |
| |
On Wed, Sep 30, 2009 at 4:20 PM, Michal Schmidt <mschmidt@redhat.com> wrote: > Dne Wed, 30 Sep 2009 16:01:40 +0800 > Yong Zhang <yong.zhang0@gmail.com> napsal(a): >> From my previous mail, I have ask Maciej to test the blow patch: >> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c >> index fb0f46f..4a00a1a 100644 >> --- a/kernel/time/timekeeping.c >> +++ b/kernel/time/timekeeping.c >> @@ -569,6 +569,9 @@ static int timekeeping_resume(struct sys_device >> *dev) unsigned long flags; >> struct timespec ts; >> >> + WARN_ONCE(!irqs_disabled(), >> + KERN_INFO "timekeeping_resume() called with IRQs >> enabled!"); + >> read_persistent_clock(&ts); >> >> clocksource_resume(); >> >> And indeed, the warning is showed. > > Is it? After Maciej tested it, he said: >> no "timekeeping_resume() called with IRQs enabled!". > which I read as: no such message was shown. >
Just check again. OMG, I'm blind for so long time. Yeah, it seem like 89133f9 fix this issue. Sorry again.
Thanks, Yong
> Michal > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |