[lkml]   [2009]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 07/29] ioat: fix type mismatch for ->dmacount
    ->dmacount tracks the sequence number of active descriptors.  It is
    written to the DMACOUNT register to update the channel's view of pending
    descriptors in the chain. The register is 16-bits so ->dmacount should
    be unsigned and 16-bit as well. Also modify ->desccount to maintain

    This was never a problem in practice because we never compared dmacount
    values, but this is a bug waiting to happen.

    Signed-off-by: Maciej Sosnowski <>
    Signed-off-by: Dan Williams <>
    drivers/dma/ioat/dma.h | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/dma/ioat/dma.h b/drivers/dma/ioat/dma.h
    index 1226e35..9f0c853 100644
    --- a/drivers/dma/ioat/dma.h
    +++ b/drivers/dma/ioat/dma.h
    @@ -102,8 +102,8 @@ struct ioat_dma_chan {
    struct delayed_work work;

    int pending;
    - int dmacount;
    - int desccount;
    + u16 dmacount;
    + u16 desccount;

    struct ioatdma_device *device;
    struct dma_chan common;

     \ /
      Last update: 2009-09-04 04:33    [W:0.019 / U:166.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site