lkml.org 
[lkml]   [2009]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] slub: Fix kmem_cache_destroy() with SLAB_DESTROY_BY_RCU
    Pekka Enberg a écrit :
    > On Thu, Sep 3, 2009 at 5:18 PM, Eric Dumazet<eric.dumazet@gmail.com> wrote:
    >> Here is the second patch (RCU thing). Stable candidate
    >>
    >> [PATCH] slub: Fix kmem_cache_destroy() with SLAB_DESTROY_BY_RCU
    >>
    >> kmem_cache_destroy() should call rcu_barrier() *after* kmem_cache_close()
    >> and *before* sysfs_slab_remove() or risk rcu_free_slab()
    >> being called after kmem_cache is deleted (kfreed).
    >>
    >> rmmod nf_conntrack can crash the machine because it has to
    >> kmem_cache_destroy() a SLAB_DESTROY_BY_RCU enabled cache.
    >
    > Do we have a bugzilla URL for this?

    Well, I can crash my 2.6.30.5 machine just doing rmmod nf_conntrack

    (You'll need CONFIG_SLUB_DEBUG_ON or equivalent)

    Original Zdenek report : http://thread.gmane.org/gmane.linux.kernel/876016/focus=876086

    >
    >> Reported-by: Zdenek Kabelac <zdenek.kabelac@gmail.com>
    >> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
    >> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    >
    > OK, this is in for-next now and queued for 2.6.31. If you guys want to
    > fix this in a different way, lets do that in 2.6.32.

    Seems the right thing IMHO
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-09-03 22:01    [W:0.024 / U:0.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site