Messages in this thread | | | Date | Tue, 29 Sep 2009 17:42:49 +0900 | From | Hidetoshi Seto <> | Subject | Re: [PATCH 3/5] mce-inject: make injected mce valid only during faked handler call |
| |
Andi Kleen wrote: >> This has an undesired side-effect: it is possible for it to be >> consumed by real machine_check_poll. This may confuse a real system >> error and may confuse the mce test suite. > > You can just disable the poll handler in the test suite. That's > what we did.
I'd like to fix this simply, rather than providing documentation like "you should turn off polling before you use the mce-inject."
>> The injectm.valid becomes "2" only during faked MCE handler call >> and protected by IRQ disabling. This make it impossible for real >> machine_check_poll to consume it. > > Using magic numbers for this seems very hackish.
Right. I'll take other approach in next time.
Thanks, H.Seto
| |