Messages in this thread | | | Date | Tue, 29 Sep 2009 23:39:52 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not used |
| |
On Tue, 29 Sep 2009 19:40:10 +0100 David Howells <dhowells@redhat.com> wrote:
> Linus Torvalds <torvalds@linux-foundation.org> wrote: > > > Comments? > > Perhaps add legacy pty support to the list of features to be removed and see > who howls.
You do break stuff still and they are part of the API, ABI and namespace so you break compatibility.
> > static struct tty_driver *pty_driver, *pty_slave_driver; > > These shouldn't be global variables. They're only used within > legacy_pty_init(). That's a side issue, however.
Agreed
| |