Messages in this thread | | | Subject | Re: [PATCH] cmpc_acpi: Added support for Classmate PC ACPI devices. | From | Joe Perches <> | Date | Tue, 29 Sep 2009 13:17:52 -0700 |
| |
On Tue, 2009-09-29 at 13:05 -0700, Andrew Morton wrote: > static acpi_status cmpc_start_accel(acpi_handle handle) > { > union acpi_object param[2]; > struct acpi_object_list input; > acpi_status status; > > param[0].type = ACPI_TYPE_INTEGER; > param[0].integer.value = 0x3; > param[1].type = ACPI_TYPE_INTEGER; > input.count = 2; > input.pointer = param; > status = acpi_evaluate_object(handle, "ACMD", &input, NULL); > return status; > } > > puts a smile on our faces.
Much better, but what appears to be incomplete initialization of stack variables is also a bit offputting.
cheers, Joe
| |