Messages in this thread Patch in this message | | | From | Philipp Reisner <> | Subject | Re: [Drbd-dev] [PATCH -next] drbd: trace depends on TRACING | Date | Tue, 29 Sep 2009 17:32:50 +0200 |
| |
On Saturday 26 September 2009 01:03:04 Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > DRBD_TRACE should depend on TRACING. > It's also possible that TRACEPOINTS should depend on TRACING. >
Hi Randy,
I tried to figure out in which way that should be done. By looking at "BLK_DEV_IO_TRACE" I got the impression that this should be done by adding "select GENERIC_TRACER".
I will further examine this tomorrow. I just wanted to let you know that this did not fall off the table...
-Phil
diff --git a/drivers/block/drbd/Kconfig b/drivers/block/drbd/Kconfig index 4e6f90f..7b35287 100644 --- a/drivers/block/drbd/Kconfig +++ b/drivers/block/drbd/Kconfig @@ -7,7 +7,7 @@ comment "DRBD disabled because PROC_FS, INET or CONNECTOR not selected"
config BLK_DEV_DRBD tristate "DRBD Distributed Replicated Block Device support" - depends on PROC_FS && INET && CONNECTOR + depends on BLOCK && PROC_FS && INET && CONNECTOR select LRU_CACHE default n help @@ -42,6 +42,7 @@ config DRBD_TRACE tristate "DRBD tracing" depends on BLK_DEV_DRBD select TRACEPOINTS + select GENERIC_TRACER default n help -- : Dipl-Ing Philipp Reisner : LINBIT | Your Way to High Availability : Tel: +43-1-8178292-50, Fax: +43-1-8178292-82 : http://www.linbit.com DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.
| |