Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] tty: fix vt_compat_ioctl | Date | Tue, 29 Sep 2009 14:49:46 +0200 |
| |
On Monday 28 September 2009, Andreas Schwab wrote: > Greg KH <gregkh@suse.de> writes: > > > On Mon, Sep 28, 2009 at 08:10:02PM +0200, Andreas Schwab wrote: > >> Call compat_unimap_ioctl, not do_unimap_ioctl. > > > > That's a nice description of what the patch does, but why do we need to > > do that? > > It's a compat ioctl handler, so lets call the compat ioctl handler. >
My bad, sorry.
I broke it in e9216651 evidently, thanks for debugging this.
The compat_unimap_ioctl was originally called do_unimap_ioctl in fs/compat_ioctl.h which got moved to drivers/char/vt_ioctl.c. In that patch, the caller was not updated and consequently called the native handler.
Acked-by: Arnd Bergmann <arnd@arndb.de>
Arnd <><
| |