Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [PATCH] USB: digi_acceleport: Fix broken unthrottle. | Date | Tue, 29 Sep 2009 14:28:33 +0200 |
| |
Am Dienstag, 29. September 2009 13:35:18 schrieb Johan Hovold: > On Tue, Sep 29, 2009 at 01:20:44PM +0200, Oliver Neukum wrote: > > Am Dienstag, 29. September 2009 12:39:23 schrieb Johan Hovold: > > > This patch is untested as I haven't got the hardware, but seems > > > straight-forward to me. > > > > > > Can you verify, Oliver? > > > > I would prefer to see a check in usb-serial.c::serial_unthrottle() > > This is completely unrelated to the unthrottle issue discussed elsewhere. > :) > > The digi_acceleport unthrottle code should (and used to) check > priv->dp_throttle_restart to determine whether to resubmit and then > cleared the flag. The commit mentioned mistakenly, I assume, reversed this. > Plain bug. Right?
Eek. Yes, sorry. Unthrotteling as I currently made it cannot work. Your fix is completely correct.
Regards Oliver
Acked-by: Oliver Neukum <oliver@neukum.org>
| |