[lkml]   [2009]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC PATCH 00/11] autofs4 - update autofs4 to deal with VFS locking change
    Sage Weil wrote:
    > On Thu, 24 Sep 2009, Ian Kent wrote:
    >> A change to the VFS path walk locking is needed to resolve an issue
    >> identified by Sage Weil. This locking change requires significant
    >> changes to the autofs4 module to allow it to callback to userspace
    >> without introducing a deadlock.
    >> To cope with the change the autofs4 module needs to redirect mount
    >> requests from ->d_revalidate() to ->lookup() if the directory
    >> inode mutex is held when a callback needs to be done. Note that we
    >> cannot redirect these requests when the mutex is not held because,
    >> to function correctly, the mutex must be held over both revalidate
    >> and lookup.
    >> Of the patches in the series most are cleanups and refactoring done
    >> to keep the real change in "autofs4 - always use lookup for lookup"
    >> as clean as possible. Unfortuneately, there is still quite a bit
    >> left in it.
    >> Also, I need confirmation that the patch that changes the VFS path
    >> walk locking is in fact correct, or at least like for like to what
    >> will be submitted. I had some difficulty with the original patches
    >> that were paosted. The patch in question below is "vfs: make
    >> real_lookup do dentry revalidation with i_mutex held".
    > It looks identical to be the original two folded into one patch. I'll
    > repost those two now, freshened against Linus' tree. The first has just
    > the functional change, and the cleanup is in the second (as per
    > Christoph's review).

    Yes, after checking, the patch I was using is functionally the same as
    the combination of the two you re-posted. So all is good for may part.


     \ /
      Last update: 2009-09-28 09:57    [W:0.022 / U:15.536 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site