[lkml]   [2009]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 3/5] mce-inject: make injected mce valid only during faked handler call
    Hidetoshi Seto wrote:

    > This has an undesired side-effect: it is possible for it to be
    > consumed by real machine_check_poll. This may confuse a real system
    > error and may confuse the mce test suite.

    You can just disable the poll handler in the test suite. That's
    what we did.

    > To fix this, this patch changes mce_rdmsrl/wemsrl() to refer injected
    > data only when injectm.valid states 3rd state "2", which indicates that
    > the injected MCE entry is valid and ready for the handler.
    > The injectm.valid becomes "2" only during faked MCE handler call
    > and protected by IRQ disabling. This make it impossible for real
    > machine_check_poll to consume it.

    Using magic numbers for this seems very hackish.


     \ /
      Last update: 2009-09-28 20:53    [W:0.021 / U:32.360 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site