Messages in this thread |  | | | Date | Sun, 27 Sep 2009 12:56:32 -0300 | | From | Cesar Eduardo Barros <> | | Subject | Re: [PATCH] WARN_ONCE(): use bool for boolean flag |
| |
Daniel Walker escreveu: > On Sun, 2009-09-27 at 10:53 -0300, Cesar Eduardo Barros wrote: >> #define >> WARN_ON_ONCE(condition) ({ \ >> - static int __warned; \ >> + static bool __warned; \ >> int __ret_warn_once = !!(condition); \ > > Could __ret_warn_once be bool also ? It looks like just another > conditional variable..
Yes, it could (as long as either it is converted back to int in the return of the macro, or all users do not care about the macro's return type). However, the justification used for the printk_once patch (and this WARN_ONCE patch) does not apply directly anymore, since the code is different (to start with, it is not a static variable). -- Cesar Eduardo Barros cesarb@cesarb.net cesar.barros@gmail.com
|  |