Messages in this thread | | | Date | Sun, 27 Sep 2009 13:05:01 -0400 (EDT) | From | Tim Abbott <> | Subject | Re: [PATCH 1/2] lib: Add generic binary search function to the kernel. |
| |
On Thu, 24 Sep 2009, Rusty Russell wrote:
> On Thu, 24 Sep 2009 02:58:45 am Tim Abbott wrote: > > +void *bsearch(const void *key, const void *base, size_t num, size_t size, > > + int (*cmp)(const void *key, const void *elt)) > > +{ > > + int start = 0, end = num - 1, mid, result; > > + if (num == 0) > > + return NULL; > > + > > + while (start <= end) { > > The if (num == 0) line is superfluous.
You are quite right.
-Tim Abbott
| |