lkml.org 
[lkml]   [2009]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Fix hwpoison code related build failure on 32-bit NUMAQ


On Sat, 26 Sep 2009, Ingo Molnar wrote:
> >
> > +config X86_SUPPORTS_MEMORY_FAILURE
> > + bool
> > + depends on !X86_NUMAQ
> > + select ARCH_SUPPORTS_MEMORY_FAILURE
> > + default y
>
> Thanks Linus, this patch fixed the NUMAQ build problem.

I think it's slightly buggy still.

I think the X86_SUPPORTS_MEMORY_FAILURE thing should also have a

depends on X86_MCE

line, because we still depend on MCE.

And as you found out, there's also the sparsemem thing.

Don't make it one huge ugly thing, just split out the requirements like

depends on X86_MCE
depends on !X86_NUMAQ
depends on X86_64 || !SPARSEMEM
because I think the requirements are fairly independent, and it makes it
easier to read (you could even comment each line on why _that_ particular
issue needs to disable X86_SUPPORTS_MEMORY_FAILURE)

But yeah, with that, and some testing, please add my sign-off (or
acked-by, if you end up changing the patch so much that it has little to
do with my original one)

Linus


\
 
 \ /
  Last update: 2009-10-18 23:28    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site