lkml.org 
[lkml]   [2009]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 2/14] bfa: Brocade BFA FC SCSI driver (bfa1)
> > Hi Daniel,
> >
> > I did run checkpatch.pl and it didn't report any ERROR or WARNING. Do
> you use any specific flags?
>
> No nothing special .. I run it in the following way,
>
> ./scripts/checkpatch.pl this-is-the-test.patch
>
> or
>
> cat this-is-the-test.patch | ./scripts/checkpatch.pl -
>
> how did you run it? Usually it will report something like the following
> if it finds nothing,
>
> total: 0 errors, 0 warnings, XXX lines checked
>
> Your patch has no obvious style problems and is ready for submission.
>
>
>
> Daniel

Thanks. I found the problem. I tried the latest checkpatch in 2.6.31 and it generates a lot of ERRORs about putting parentheses for return. I have been using an older version of checkpatch for patch submission all the time, and therefore I didn't see any problem. I will fix them and resubmit the patch.

Jing



\
 
 \ /
  Last update: 2009-09-24 20:11    [W:1.539 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site