Messages in this thread | | | Date | Wed, 23 Sep 2009 11:11:15 +0800 | From | Wu Fengguang <> | Subject | Re: regression in page writeback |
| |
On Wed, Sep 23, 2009 at 10:56:05AM +0800, Andrew Morton wrote: > On Wed, 23 Sep 2009 10:49:58 +0800 Wu Fengguang <fengguang.wu@intel.com> wrote: > > > > After the sleep we repoll all queues. > > > > I mean, it is not always necessary. Only when _all_ superblocks cannot > > writeback their inodes (eg. all in congestion), we should wait. > > Well. The code will still submit MAX_WRITEBACK_PAGES pages to _some_ > queue in that situation. > > But yup, maybe that's a bug! Sounds easy to fix. It doesn't justify > rewriting the whole world and then saying "look, the new code is faster > than the old code which had a bug which I knew about but didn't fix".
I didn't submit the patches to avoid conflicts with Jens' work. Sorry for doing that - that's not good attitude towards bug fixes..
Thanks, Fengguang
| |