lkml.org 
[lkml]   [2009]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 19/24] ftrace: Fix trace_add_event_call() to initialize list
    > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
    > index ba34920..83cc2c0 100644
    > --- a/kernel/trace/trace_events.c
    > +++ b/kernel/trace/trace_events.c
    > @@ -1010,9 +1010,12 @@ static int __trace_add_event_call(struct ftrace_event_call *call)
    > return -ENOENT;
    >
    > list_add(&call->list, &ftrace_events);
    > - return event_create_dir(call, d_events, &ftrace_event_id_fops,
    > + ret = event_create_dir(call, d_events, &ftrace_event_id_fops,
    > &ftrace_enable_fops, &ftrace_event_filter_fops,
    > &ftrace_event_format_fops);
    > + if (ret < 0)
    > + list_del(&call->list);
    > + return ret;

    seems it's a bit better to call list_add() after event_create_dir()
    returns 0.

    > }
    >
    > /* Add an additional event_call dynamically */


    \
     
     \ /
      Last update: 2009-09-23 03:15    [W:0.022 / U:4.220 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site