Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] PCI PM: Read device power state from register after updating it (rev. 2) | Date | Tue, 22 Sep 2009 21:51:35 +0200 |
| |
On Tuesday 22 September 2009, Arjan van de Ven wrote: > On Mon, 21 Sep 2009 23:37:01 +0200 > "Rafael J. Wysocki" <rjw@sisk.pl> wrote: > > > > - dev->current_state = state; > > + pci_read_config_word(dev, dev->pm_cap + PCI_PM_CTRL, &pmcsr); > > + dev->current_state = (pmcsr & PCI_PM_CTRL_STATE_MASK); > > + /* Return error code if we have failed to change the state */ > > + if (dev->current_state != state) > > + dev_info(&dev->dev, "Refused to change power state, " > > + "currently in D%d\n", dev->current_state); > > I would suspect that you want this message only once... > to avoid it flooding logs and such
Hmm? I don't think we use pci_set_power_state() _that_ often.
> or at least ratelimiting it
That sounds like a good idea, though, will respin.
| |