lkml.org 
[lkml]   [2009]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/4] module: extract __ExPORT_SYMBOL from module.h into mod_export.h
    From
    Date
    On Tue, 2009-09-22 at 14:38 +0100, Alan Jenkins wrote:
    > +
    > +struct kernel_symbol
    > +{
    > + unsigned long value;
    > + const char *name;
    > +};

    One relevant checkpatch error above,

    ERROR: open brace '{' following struct go on the same line
    #71: FILE: include/linux/mod_export.h:13:
    +struct kernel_symbol
    +{

    You have another similar one in patch 4 ,

    ERROR: else should follow close brace '}'
    #99: FILE: kernel/module.c:221:
    + }
    + else if (cmp < 0)


    Could you correct those?

    Daniel



    \
     
     \ /
      Last update: 2009-09-22 17:47    [W:0.021 / U:89.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site