lkml.org 
[lkml]   [2009]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] perf_counter/powerpc: Fix compilation after perf_counter_overflow change
    On Mon, Sep 21, 2009 at 09:30:43AM +0200, Ingo Molnar wrote:
    >
    > * Metzger, Markus T <markus.t.metzger@intel.com> wrote:
    >
    > > >-----Original Message-----
    > > >From: Paul Mackerras [mailto:paulus@samba.org]
    > > >Sent: Monday, September 21, 2009 8:45 AM
    > >
    > >
    > > >Markus, please take care in future to mention it in the changelog if
    > > >your patches touch definitions used by other architectures. If you
    > > >could go so far as to use grep a bit more and fix up other
    > > >architectures' callsites for the things you're changing, that would be
    > > >very much appreciated. Thanks.
    > >
    > > I'm sorry I missed that.
    > >
    > > There's one more place in arch/sparc/.
    > > The below patch should fix it, but I have no means to test it.
    >
    > You also missed a third thing:
    >
    > +static inline int
    > +perf_output_begin(struct perf_output_handle *handle, struct perf_counter *c,
    > + unsigned int size, int nmi, int sample) { }
    >
    > an 'int' function returning void ...
    >
    > Plus all the !PERF_COUNTERS branch of empty inlines is pointless - these
    > facilities are used by perfcounters code only. I fixed that too.

    Hi Ingo,

    did you fix all of these warnings for !PERF_COUNTERS?

    include/linux/perf_counter.h: In function 'perf_output_begin':
    include/linux/perf_counter.h:854: warning: no return statement in function returning non-void
    include/linux/perf_counter.h: At top level:
    include/linux/perf_counter.h:863: warning: 'struct perf_sample_data' declared inside parameter list
    include/linux/perf_counter.h:863: warning: its scope is only this definition or declaration, which is probably not what you want
    include/linux/perf_counter.h:868: warning: 'struct perf_sample_data' declared inside parameter list


    \
     
     \ /
      Last update: 2009-09-21 09:41    [W:0.024 / U:1.828 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site