lkml.org 
[lkml]   [2009]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/2] vfs: fix d_path() for unreachable paths
    On Mon, Sep 21, 2009 at 10:43, Al Viro wrote:
    > On Mon, Sep 21, 2009 at 03:38:57PM +0100, Al Viro wrote:
    >> On Mon, Sep 21, 2009 at 10:10:17AM -0400, Mike Frysinger wrote:
    >> > it works without having to copy & paste the same exact structures over
    >> > and over.  a suggestion as how to do it cleanly without bloating the
    >> > code is certainly welcome.  it doesnt really matter that it's on the
    >> > stack as the usage is small and d_path() is given the size of the
    >> > buffer, so it isnt going to overflow.
    >
    > PS: as to why it is broken...  Consider e.g.
    >        mount --bind /proc/cplbinfo/cpu0 /mnt
    >        cat /mnt/icplb
    > Or, better yet,
    >        mount -t proc none /mnt/cpu
    >        cat /mnt/cpu/cplbinfo/cpu0/icplb

    i'm not disagreeing that it doesnt work under all random VFS
    scenarios. just that the realistic ones all work.
    -mike
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-09-21 17:35    [W:0.045 / U:34.004 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site