lkml.org 
[lkml]   [2009]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/1] kthreads: simplify !kthreadd_task logic, kill kthreadd_task_init_done
    On 09/01, Eric W. Biederman wrote:
    >
    > Oleg Nesterov <oleg@redhat.com> writes:
    >
    > > On 09/01, Oleg Nesterov wrote:
    > >>
    > >> On 09/01, Ingo Molnar wrote:
    > >> >
    > >> > * Oleg Nesterov <oleg@redhat.com> wrote:
    > >> >
    > >> > > On 09/01, Ingo Molnar wrote:
    > >> > > >
    > >> > > > * Oleg Nesterov <oleg@redhat.com> wrote:
    > >> > > >
    > >> > > > > Yes, this should work. But I _think_ we can make the better fix...
    > >> > > > >
    > >> > > > > I'll try to make the patch soon. Afaics we don't need
    > >> > > > > kthreadd_task_init_done.
    > >> > > >
    > >> > > > ok.
    > >> > >
    > >> > > Just in case, the patch is ready. [...]
    > >> >
    > >> > yes - that's roughly the cleanup i referred to in the commit log.
    > >> >
    > >> > way too late for -rc8 though - the minimal fix i did _might_ be
    > >> > eligible.
    > >> >
    > >> > agreed?
    > >>
    > >> Agreed. Then I will sent the patch on top of this change.
    > >
    > > OK, I am sending the patch on top of your fix. Not sure how to really
    > > test it, but at least the kernel works when I apply the debugging patch
    > > below on top.
    >
    > Stupid question. How is it that we wind up trying to start kernel threads
    > before it is safe to do so?
    >
    > Races should be impossible because the scheduler isn't running until a few
    > lines later.

    Yes, I am confused too.

    At first I thought I understand the race, now I don't. Please see the whole
    thread: http://marc.info/?t=125180592500005

    Oleg.



    \
     
     \ /
      Last update: 2009-09-02 11:21    [W:0.037 / U:31.820 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site