lkml.org 
[lkml]   [2009]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 67/79] tty: USB: serial/mct_u232, fix tty refcnt
    Date
    From: Jiri Slaby <jirislaby@gmail.com>

    Stanse found a tty refcnt leak in read_int_callback. In fact
    it's handled wrong altogether. tty_port_tty_get can return NULL
    and it's not checked in that manner.

    Fix that by checking the tty_port_tty_get retval and put tty kref
    properly.

    http://stanse.fi.muni.cz/

    Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/usb/serial/mct_u232.c | 9 ++++++---
    1 files changed, 6 insertions(+), 3 deletions(-)

    diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c
    index d501aef..ad4998b 100644
    --- a/drivers/usb/serial/mct_u232.c
    +++ b/drivers/usb/serial/mct_u232.c
    @@ -566,10 +566,13 @@ static void mct_u232_read_int_callback(struct urb *urb)
    * Work-a-round: handle the 'usual' bulk-in pipe here
    */
    if (urb->transfer_buffer_length > 2) {
    - tty = tty_port_tty_get(&port->port);
    if (urb->actual_length) {
    - tty_insert_flip_string(tty, data, urb->actual_length);
    - tty_flip_buffer_push(tty);
    + tty = tty_port_tty_get(&port->port);
    + if (tty) {
    + tty_insert_flip_string(tty, data,
    + urb->actual_length);
    + tty_flip_buffer_push(tty);
    + }
    tty_kref_put(tty);
    }
    goto exit;
    --
    1.6.4.2


    \
     
     \ /
      Last update: 2009-09-20 00:15    [W:0.023 / U:212.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site