Messages in this thread | | | From | Mike Frysinger <> | Date | Sat, 19 Sep 2009 15:08:39 -0400 | Subject | Re: [PATCH 05/17] Blackfin: convert to generic checksum code |
| |
On Tue, Jun 23, 2009 at 17:14, Arnd Bergmann wrote: > On Friday 19 June 2009, Mike Frysinger wrote: >> > >> > sounds like a good idea. >> >> how about the attached > > Mostly good, but needs some improvements. At least it helped me > track down the last problem. > >> > lib/checksum.c: Fix another endianess bug >> >> hrm, still not quite :/ >> >> the attached test code shows failures in every case > > When I tried running it on x86-64, it only showed failures for > numbers 1, 2 and 4. I fixed them with this patch: > --- > lib/checksum: fix one more thinko > > When do_csum gets unaligned data, we really need to treat > the first byte as an even byte, not an odd byte, because > we swap the two halves later. > > Found by Mike's checksum-selftest module. > > Reported-by: Mike Frysinger <vapier.adi@gmail.com> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
shouldnt this fix have been in 2.6.31 ? doesnt seem to be even in latest git ... -mike
| |