lkml.org 
[lkml]   [2009]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] ipv4: make do_ip_setsockopt for IP_MULTICAST_IF support ip_mreq struct
    Xiaotian Feng wrote, at 09/17/2009 01:20 PM:
    > ip_mreq and ip_mreqn is almost the same, and do_ip_setsockopt for IP_MULTICAST_IF
    > part supported ip_mreqn struct. This patch adds support for ip_mreq struct.
    >

    It's not meaning to support the ip_mreq struct, the imr_multiaddr member
    never be used by the IP_MULTICAST_IF.

    In addition, using the option normally like this:
    struct in_addr interface_addr;
    setsockopt (socket, IPPROTO_IP, IP_MULTICAST_IF, &interface_addr, sizeof(interface_addr));

    Do your patch suggest using the option like this?
    struct ip_mreq mreq;
    setsockopt (socket, IPPROTO_IP, IP_MULTICAST_IF, &mreq, sizeof(mreq));


    Best Regards
    -----
    Shan Wei


    \
     
     \ /
      Last update: 2009-09-17 11:15    [W:0.025 / U:60.332 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site