lkml.org 
[lkml]   [2009]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/5] Blackfin SPI: work around anomaly 05000119
    Date
    From: Sonic Zhang <sonic.zhang@analog.com>

    Anomaly 05000119 states that the DMA_RUN bit with peripherals isn't
    reliable. However, the way the driver is currently written (DMA IRQ
    callback), we don't need the polling in the first place, so drop it.

    Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
    Signed-off-by: Mike Frysinger <vapier@gentoo.org>
    ---
    drivers/spi/spi_bfin5xx.c | 4 ----
    1 files changed, 0 insertions(+), 4 deletions(-)

    diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c
    index 8ec4969..5591bce 100644
    --- a/drivers/spi/spi_bfin5xx.c
    +++ b/drivers/spi/spi_bfin5xx.c
    @@ -539,10 +539,6 @@ static irqreturn_t bfin_spi_dma_irq_handler(int irq, void *dev_id)

    clear_dma_irqstat(drv_data->dma_channel);

    - /* Wait for DMA to complete */
    - while (get_dma_curr_irqstat(drv_data->dma_channel) & DMA_RUN)
    - cpu_relax();
    -
    /*
    * wait for the last transaction shifted out. HRM states:
    * at this point there may still be data in the SPI DMA FIFO waiting
    --
    1.6.5.rc1


    \
     
     \ /
      Last update: 2009-09-18 01:51    [W:0.020 / U:61.784 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site