lkml.org 
[lkml]   [2009]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [patch] Makefile: can't build modules outside the kernel tree if it was built using O=
    From
    sadly, some 3rd party src packages don't quite do the right thing with
    their kernel include paths and still depend on the include2/asm symlink
    to find the platform header files.

    i see your point about include2 being somewhat redundant/legacy, however,
    as long as we are creating it, we should have it point to the intended
    location instead of being a dead link!

    On Thu, Sep 17, 2009 at 4:45 AM, Arnd Bergmann <arnd@arndb.de> wrote:
    > On Thursday 17 September 2009, Caveh Jalali wrote:
    >
    >> when the platform specific include directories were shuffled around
    >> without updating the
    >> top level Makefile.  however, i think this FAIL is generic, and not
    >> limited to powerpc.
    >> here's a patch to the top level Makefile to teach it about the shuffled files:
    >>
    >>
    >> --- /local/caveh/linux/linux-2.6.31/Makefile    2009-09-09
    >> 15:13:59.000000000 -0700
    >> +++ Makefile    2009-09-16 12:23:05.000000000 -0700
    >> @@ -958,9 +958,9 @@ ifneq ($(KBUILD_SRC),)
    >>                 echo "  in the '$(srctree)' directory.";\
    >>                 /bin/false; \
    >>         fi;
    >> -       $(Q)if [ ! -d include2 ]; then                                  \
    >> -           mkdir -p include2;                                          \
    >> -           ln -fsn $(srctree)/include/asm-$(SRCARCH) include2/asm;     \
    >> +       $(Q)if [ ! -d include2 ]; then                                   \
    >> +           mkdir -p include2;                                           \
    >> +           ln -fsn $(srctree)/arch/$(SRCARCH)/include/asm include2/asm; \
    >>         fi
    >>  endif
    >
    > I think we should no longer have the include2 directory at all with new kernels.
    >
    > LINUXINCLUDE already contains the right path in theory:
    >
    > LINUXINCLUDE    := -Iinclude \
    >                   $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \
    >                   -I$(srctree)/arch/$(hdr-arch)/include               \
    >                   -include include/linux/autoconf.h
    >
    > I'm not sure what goes wrong here. What is the gcc command line you see?
    >
    >        Arnd <><
    >



    --
    00c
    http://www.boincstats.com/signature/user_870433_project5.gif
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-09-17 23:59    [W:0.027 / U:29.528 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site