lkml.org 
[lkml]   [2009]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] sparc: Clean up linker script using new linker script macros.
From
From: Tim Abbott <tabbott@ksplice.com>
Date: Wed, 16 Sep 2009 13:27:43 -0400 (EDT)

> On Wed, 16 Sep 2009, David Miller wrote:
>
>> Can you do this cleanup without moving the relative locations of .data
>> and .data1 sections?
>
> Yes, if you just swap RW_DATA_SECTION and .data1 so it looks like
>
> RW_DATA_SECTION(SMP_CACHE_BYTES, 0, THREAD_SIZE)
> .data1 : {
> *(.data1)
> }
>
> instead, that would preserve their relative locations.
>
> Currently, switching to RW_DATA_SECTION would still result in a change in
> their relative position that .data.page_aligned and .data.nosave would be
> between .data and .data1 (not sure if that is relevant on sparc). (this
> will change when <http://lkml.org/lkml/2009/9/16/396> is merged).

I don't know which, if any, are relevant or could cause problems.

It's hard for me to ACK this because it's not a straight nop
transformation, which we could at least presume would function
properly if the macros were implemented correctly.


\
 
 \ /
  Last update: 2009-09-16 19:33    [W:0.063 / U:0.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site