lkml.org 
[lkml]   [2009]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] arm: remove unused code in delay.S
Date
Dne Út 15. září 2009 21:44:35 Steve Chen napsal(a):
> Felipe,
>
> Here is the updated patch. If you don't mind add your signed-off, I can
> submit the patch.

Do you guys really have so much free time on your hands to argue about this?
btw. here's my nitpick then -- 'accurate delays' is really bad way to call it
;-)
>
> Regards,
>
> Steve
>
> Document #if 0 code block in delay.S and make it selectable for compile.
>
> Signed-off-by: Steve Chen <schen@mvista.com>
>
> ---
>
> arch/arm/Kconfig | 8 ++++++++
> arch/arm/lib/delay.S | 2 +-
> 2 files changed, 9 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index aef63c8..ca8d535 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -813,6 +813,14 @@ config ARM_ERRATA_460075
> ACTLR register. Note that setting specific bits in the ACTLR
> register
> may not be available in non-secure mode.
>
> +config OLD_CPU_DELAY
> + depends on CPU_32v3 || CPU_32v4 || CPU_32v4T
> + bool "Accurate delays"
> + def_bool n
> + help
> + Enable if observing longer than expected delays and need more
> + accuracy. This only applies to older CPUs.
> +
> endmenu
>
> source "arch/arm/common/Kconfig"
> diff --git a/arch/arm/lib/delay.S b/arch/arm/lib/delay.S
> index 8d6a876..67e679b 100644
> --- a/arch/arm/lib/delay.S
> +++ b/arch/arm/lib/delay.S
> @@ -42,7 +42,7 @@ ENTRY(__const_udelay) @ 0 <= r0 <= 0x7fffff06
> @ Delay routine
> ENTRY(__delay)
> subs r0, r0, #1
> -#if 0
> +#ifdef CONFIG_OLD_CPU_DELAY
> movls pc, lr
> subs r0, r0, #1
> movls pc, lr
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-09-15 22:43    [W:0.105 / U:9.748 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site