lkml.org 
[lkml]   [2009]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/11] Use unreachable() in asm-generic/bug.h for !CONFIG_BUG case.


On Mon, 14 Sep 2009, David Daney wrote:
>
> The existing code just falls through to whatever happens to follow the BUG().

Brian was talking BUG_ON().

And the existing !CONFIG_BUG BUG_ON() is actually set up so that gcc will
just optimize it away entirely (yet give the same compile-time warnings as
the "real" BUG_ON() does).

Changing it to "if (cond) unreachable()" is likely to generate _more_
code, which is against the whole point of wanting to disable CONFIG_BUG.
Linus


\
 
 \ /
  Last update: 2009-10-18 23:28    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site