Messages in this thread | | | Date | Mon, 14 Sep 2009 08:33:16 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCHv3 3/3] [PATCHv3 3/3] tracing - trace parser support for set_graph_function set_ftrace_filter set_ftrace_notrace |
| |
On Fri, Sep 11, 2009 at 03:20:10PM -0400, Steven Rostedt wrote: > Nit - fix your scripts again. The subject duplicates the [PATCHv3 3/3]. oh crap, sry
> > On Fri, 2009-09-11 at 17:29 +0200, jolsa@redhat.com wrote: > > > Fixed minor in set_graph_function display - g_show function. > > > @@ -2499,7 +2456,7 @@ static int g_show(struct seq_file *m, void *v) > > return 0; > > } > > > > - seq_printf(m, "%pf\n", v); > > + seq_printf(m, "%p\n", (void *) *ptr); > > > > return 0; > > } > > > I changed this, because it has a bug itself. You just changed the way > set_graph_function works. > > It use to do: > > # echo sys_open > set_graph_function > # cat set_graph_function > sys_open > > After this change, it does > > # echo sys_open > set_graph_function > # cat set_graph_function > ffffffff811020d0 > > Which is not very helpful.
holly crap on a cracker... I did not know vsnprintf has the %pf spec.. cool ;)
thanks, jirka
| |