lkml.org 
[lkml]   [2009]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/5] kbuild: fix warning when domainname is not available
    .
    On Sun, Sep 13, 2009 at 17:42, Felipe Contreras
    <felipe.contreras@gmail.com> wrote:
    > On Mon, Sep 14, 2009 at 12:12 AM, Mike Frysinger <vapier.adi@gmail.com> wrote:
    >> On Sun, Sep 13, 2009 at 15:38, Felipe Contreras wrote:
    >>> +  if $domain; then
    >>
    >> is this really correct ?  i think you meant to use:
    >> [ -n "$domain" ]
    >
    > What is the difference?
    >
    > $domain unset
    > test -n "" -> false
    > test -> false
    >
    > $domain is a valid string
    > test -n "string" -> true
    > test "string" -> true

    except that you didnt invoke `test` anywhere. you're executing the
    contents of $domain.
    -mike
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-09-14 00:01    [W:0.026 / U:0.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site