lkml.org 
[lkml]   [2009]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] tracing/function-graph: x86_64 stack allocation cleanup
On Sat, Sep 12, 2009 at 11:05:45PM -0400, Steven Rostedt wrote:
> From: Jiri Olsa <jolsa@redhat.com>
>
> Only 24 bytes needs to be reserved on the stack for the function graph
> tracer on x86_64.
>
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> LKML-Reference: <20090729085837.GB4998@jolsa.lab.eng.brq.redhat.com>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> ---
> arch/x86/kernel/entry_64.S | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
> index c251be7..d59fe32 100644
> --- a/arch/x86/kernel/entry_64.S
> +++ b/arch/x86/kernel/entry_64.S
> @@ -146,7 +146,7 @@ ENTRY(ftrace_graph_caller)
> END(ftrace_graph_caller)
>
> GLOBAL(return_to_handler)
> - subq $80, %rsp
> + subq $24, %rsp


That's theoretically a good fix.

But Steve, do you remember the weird issues we had while only
saving the theoretically strict needed stack space here?

It made the function graph tracer crashing in x86-64, and we
never found out why we needed to save more stack than needed.

Sorry that may sound like a FUD message but I can't explain
the reason of this, and I fear we may met it again.

Well, at least that may help us finding out the real resons of
such crashes, but...



\
 
 \ /
  Last update: 2009-09-13 19:07    [W:0.204 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site