Messages in this thread | | | Subject | Re: [PATCH tip/core/rcu 2/4] Add debug checks to TREE_PREEMPT_RCU for premature grace periods. | From | Daniel Walker <> | Date | Sun, 13 Sep 2009 09:23:02 -0700 |
| |
On Sun, 2009-09-13 at 09:15 -0700, Paul E. McKenney wrote: > From: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > > Check to make sure that there are no blocked tasks for the previous > grace period while initializing for the next grace period, verify > that rcu_preempt_qs() is given the correct CPU number and is never > called for an offline CPU. >
You've got a couple of whitespace issues in the WARN_ON_ONCE() lines.. As found by checkpatch,
ERROR: code indent should use tabs where possible #97: FILE: kernel/rcutree_plugin.h:89: +^I ^IWARN_ON_ONCE(cpu != smp_processor_id());$
ERROR: code indent should use tabs where possible #109: FILE: kernel/rcutree_plugin.h:111: +^I ^IWARN_ON_ONCE((rdp->grpmask & rnp->qsmaskinit) == 0);$
Could you fix these up?
Daniel
| |