Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [RFC][v6][PATCH 0/9] clone_with_pids() syscall | Date | Sun, 13 Sep 2009 16:36:47 +0200 |
| |
On Saturday 12 September 2009, Sukadev Bhattiprolu wrote: > > Peter Zijlstra [peterz@infradead.org] wrote: > | On Fri, 2009-09-11 at 09:47 -0700, Sukadev Bhattiprolu wrote: > | > | Also, if you're passing a struct, why not put nr_pids in there, and > | > | replace clone_pid_struct with a simple array? That would give us > | > | > | > | struct clone_struct { > | > | u64 flags; > | > | u64 child_stack; > | > | u32 child_tid; > | > | u32 parent_tid; > > BTW, these two tids are __user pointers that kernel copies data into. > They should be u64 to avoid conversions in architecture specific code ? >
No, they are not pointers, the kernel can directly write into the user data structure. Indirect pointers would not be helpful here IMHO.
Arnd <><
| |