lkml.org 
[lkml]   [2009]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC][v6][PATCH 0/9] clone_with_pids() syscall
Date
On Saturday 12 September 2009, Sukadev Bhattiprolu wrote:
>
> Peter Zijlstra [peterz@infradead.org] wrote:
> | On Fri, 2009-09-11 at 09:47 -0700, Sukadev Bhattiprolu wrote:
> | > | Also, if you're passing a struct, why not put nr_pids in there, and
> | > | replace clone_pid_struct with a simple array? That would give us
> | > |
> | > | struct clone_struct {
> | > | u64 flags;
> | > | u64 child_stack;
> | > | u32 child_tid;
> | > | u32 parent_tid;
>
> BTW, these two tids are __user pointers that kernel copies data into.
> They should be u64 to avoid conversions in architecture specific code ?
>

No, they are not pointers, the kernel can directly write into the user
data structure. Indirect pointers would not be helpful here IMHO.

Arnd <><


\
 
 \ /
  Last update: 2009-09-13 16:41    [W:0.058 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site