[lkml]   [2009]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] Fix proc_file_write missing ppos update
    On Sun, Aug 30, 2009 at 09:05:44PM +0200, Stefani Seibold wrote:
    > Switching all users of read_proc_t/write_proc_t to file operation is a
    > huge job. About 180 files must be fixed.
    > But the main reason not to do this is because the breakage of "out of
    > tree" drivers.

    > I like the current simplified proc interface. It saves a lot of code
    > duplication because the basic operations will be handled inside the
    > kernel and not in the driver.

    _What_ code duplication? Would that be
    struct proc_dir_entry *pde = PDE(file->f_path.dentry->d_inode);
    and calculation of pde->data currently done by proc_file_write()?
    Pardon me, but that's hard to take seriously. As for the ->read() side,
    most of those suckers end up switched to use of seq_read() and there's
    not a lot of boilerplate code in the resulting variants...

     \ /
      Last update: 2009-09-12 17:31    [W:0.028 / U:20.000 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site