Messages in this thread | | | Subject | Re: [PATCH] [16/21] HWPOISON: The high level memory error handler in the VM v7 | From | Daniel Walker <> | Date | Fri, 11 Sep 2009 12:38:24 -0700 |
| |
On Fri, 2009-09-11 at 21:33 +0200, Andi Kleen wrote: > > The rest of your patches are totally clean, except this one .. It has > > some warning, but one error in the second ifdef block above .. > > That's intentional, fixing it would require a bare , on a single line > which would be far uglier what is there today. I refuse to make code > ugly just to work around checkpatch.pl > > -Andi
Here's the error,
ERROR: space required after that ',' (ctx:ExV) #1086: FILE: fs/proc/meminfo.c:148: + ,atomic_long_read(&mce_bad_pages) << (PAGE_SHIFT - 10) ^
I think it just wants a space after the comma .. Couldn't you also break up these printk's so the two ifdef'ed parts are combined into a single printk that just adds on to the prior print out?
Daniel
| |