lkml.org 
[lkml]   [2009]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] char/tty_io: fix legacy pty name when more than 256 pty devices are requested
On 09/09/2009 09:05 PM, Mauro Carvalho Chehab wrote:
> {
> + static char ptychar[] = "pqrstuvwxyzabcde";
> +

Oh yes, this should be "static const char ...".

> + * The second nibble encoded with ptychar;
> + * The first nibble, printed in hexadecimal;
> + * The other nibbles, printed in hexadecimal.

The last two are in the wrong order (and you reversed the order of the
code from my example, which made that harder to see.)

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2009-09-10 08:29    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site