Messages in this thread | | | From | Frans Pop <> | Subject | Re: [PATCH 5/6] thermal: Only set passive_delay for forced passive cooling | Date | Thu, 10 Sep 2009 18:07:12 +0200 |
| |
Hi Matthew,
On Wednesday 26 August 2009, Matthew Garrett wrote: > On Wed, Aug 26, 2009 at 06:17:24PM +0200, Frans Pop wrote: > > Setting polling_delay is useless as passive_delay has priority, > > so the value shown in proc isn't the actual polling delay. It > > also gives the impression to the user that he can change the > > polling interval through proc, while in fact he can't. > > > > Also, unset passive_delay when the forced passive trip point is > > unbound to allow polling to be disabled. > > > > Signed-off-by: Frans Pop <elendil@planet.nl> > > Cc: Matthew Garrett <mjg@redhat.com> > > Cc: Zhang Rui <rui.zhang@intel.com> > > I'll look over this - I seem to remember having some reason to set > that, but it escapes me now.
Have you had a chance to check this?
Cheers, FJP
| |