Messages in this thread | | | Subject | Re: [PATCH 4/5] hw-breakpoints: Arbitrate access to pmu following registers constraints | From | Peter Zijlstra <> | Date | Thu, 10 Sep 2009 16:57:15 +0200 |
| |
On Thu, 2009-09-10 at 07:41 -0700, Daniel Walker wrote: > On Thu, 2009-09-10 at 10:29 +0200, Frederic Weisbecker wrote: > > > +static unsigned int max_task_bp_pinned(int cpu) > > { > > - if (atomic_inc_return(&bp_slot) == HBP_NUM) { > > - atomic_dec(&bp_slot); > > + int i; > > + unsigned int *tsk_pinned = per_cpu(task_bp_pinned, cpu); > > > > - return -ENOSPC; > > + for (i = HBP_NUM -1; i >= 0; i--) { > > + if (tsk_pinned[i] > 0) > > + return i + 1; > > } > > One checkpatch error in the code above.. > > ERROR: need consistent spacing around '-' (ctx:WxV) > #206: FILE: kernel/hw_breakpoint.c:81: > + for (i = HBP_NUM -1; i >= 0; i--) { > ^
Don't you have anything useful to do?
| |