Messages in this thread |  | | | Date | Thu, 10 Sep 2009 21:28:30 +1000 | | From | Paul Mackerras <> | | Subject | Re: [PATCH 2/5] perf_counter: Export various perf helpers for external users |
| |
Frederic Weisbecker writes:
> Export various perf helpers that initialize, destroy, attach and detach > a perf counter for future external users like the hardware breakpoint api.
You are exporting things that are quite deep into the guts of the perf_counter code, which makes me think that what you're exporting isn't the right abstraction. At the least, your commit message needs to talk about what these external users want to do and why they need to reach so deeply into the perf_counter internals.
> The allocation and initialization of a perf counter have been split up > so that an external user can first allocate and then prefill the > counter before initialize it properly.
Once again, this sounds like the wrong abstraction to me. Can you explain why first allocating and then prefilling it before initializing it properly is necessary or desirable?
Paul.
|  |