Messages in this thread | | | Date | Tue, 1 Sep 2009 14:47:51 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 1/2] AB3100 regulator support v2 |
| |
On Sun, Aug 30, 2009 at 11:29:09PM +0200, Linus Walleij wrote: > This adds support for the regulators found in the AB3100 > Mixed-Signal IC.
Not sure why I was cc'd on this, but only one comment from me...
> +/* Preset (hardware defined) voltages for these regulators */ > +#define LDO_A_VOLTAGE 2750000 > +#define LDO_C_VOLTAGE 2650000 > +#define LDO_D_VOLTAGE 2650000 > + > +int ldo_e_buck_typ_voltages[] = { > + 1800000, > + 1400000, > + 1300000, > + 1200000, > + 1100000, > + 1050000, > + 900000, > +}; > + > +int ldo_f_typ_voltages[] = { > + 1800000, > + 1400000, > + 1300000, > + 1200000, > + 1100000, > + 1050000, > + 2500000, > + 2650000, > +}; > + > +int ldo_g_typ_voltages[] = { > + 2850000, > + 2750000, > + 1800000, > + 1500000, > +}; > + > +int ldo_h_typ_voltages[] = { > + 2750000, > + 1800000, > + 1500000, > + 1200000, > +}; > + > +int ldo_k_typ_voltages[] = { > + 2750000, > + 1800000, > +};
Is there a reason for these to be globally visible?
| |