lkml.org 
[lkml]   [2009]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/8] writeback: move super_block argument to struct writeback_control
    On Tue, Sep 01, 2009 at 01:18:59PM +0200, Jens Axboe wrote:
    > Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
    > ---
    > fs/ubifs/super.c | 3 ++-
    > include/linux/fs.h | 3 +--
    >
    > diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
    > @@ -462,7 +463,7 @@ static int ubifs_sync_fs(struct super_block *sb, int wait)
    > * the user be able to get more accurate results of 'statfs()' after
    > * they synchronize the file system.
    > */
    > - generic_sync_sb_inodes(sb, &wbc);
    > + generic_sync_sb_inodes(&wbc);
    >
    > /*
    > * Synchronize write buffers, because 'ubifs_run_commit()' does not

    I just tried compiling per-bdi v15 against the latest git HEAD, and
    the compilation failed:

    fs/ubifs/super.c: In function ‘ubifs_sync_fs’:
    fs/ubifs/super.c:465: warning: passing argument 1 of ‘generic_sync_sb_inodes’ from incompatible pointer type
    fs/ubifs/super.c:465: error: too many arguments to function ‘generic_sync_sb_inodes’

    Looks like the latest version of fs/ubifs/super.c added a call to
    generic_sync_sb_inodes that needs to be fixed up. Line 465:

    generic_sync_sb_inodes(sb, &wbc);

    - Ted
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-09-01 13:59    [W:0.022 / U:34.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site