lkml.org 
[lkml]   [2009]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Driver Core: devtmpfs - kernel-maintained tmpfs-based /dev
    Hi!

    > --- /dev/null
    > +++ b/drivers/base/devtmpfs.c
    > @@ -0,0 +1,367 @@
    > +/*
    > + * devtmpfs - kernel-maintained tmpfs-based /dev
    > + *
    > + * Copyright (C) 2009, Kay Sievers <kay.sievers@vrfy.org>
    > + *

    I'd expect GPL notice here...

    > +#if defined CONFIG_DEVTMPFS_MOUNT
    > +static int dev_mount = 1;
    > +#else
    > +static int dev_mount;
    > +#endif


    A bit too many config options?

    > +#ifdef CONFIG_BLOCK
    > +static inline int is_blockdev(struct device *dev)
    > +{
    > + return dev->class == &block_class;
    > +}
    > +#else
    > +static inline int is_blockdev(struct device *dev) { return 0; }

    Should this go to header somewhere?

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2009-08-09 14:11    [W:0.038 / U:1.020 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site