Messages in this thread | | | Subject | Re: [PATCH 1/8] Regulator: Add TPS65023 regulator driver | From | Liam Girdwood <> | Date | Sun, 09 Aug 2009 12:20:55 +0100 |
| |
On Fri, 2009-08-07 at 16:53 +0100, Mark Brown wrote: > On Fri, Aug 07, 2009 at 08:55:26PM +0530, Anuj Aggarwal wrote: >
> > +static const struct tps_info tps65023_regs[] = { > > + { > > + .name = "VDCDC1", > > + .min_uV = 800000, > > + .max_uV = 1600000, > > + .fixed = 0,
No need to add fixed = 0 in this array as compiler will do this for you.
> > + .table_len = ARRAY_SIZE(VDCDC1_VSEL_table), > > + .table = VDCDC1_VSEL_table, > > + }, > > Indentation here is a bit non-standard - I'd expect either the {} around > the elements to be in column 0 or another level of indentation for the > fields. > > > + { > > + .name = "VDCDC2", > > + .min_uV = 3300000, > > + .max_uV = 3300000, > > + .fixed = 1, > > + .table_len = 0, > > + }, > > You could drop the fixed flag and just have fixed be inferred from > min_uV == max_uV? >
To be honest I prefer having the fixed = 1 here. It stands out more and imho keeps things simple. Also table_len could be omitted.
Thanks
Liam
| |