lkml.org 
[lkml]   [2009]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH] PM: kill dev_pm_ops platform warning for now
    Date
    On Friday 07 August 2009, Magnus Damm wrote:
    > From: Magnus Damm <damm@igel.co.jp>
    >
    > Remove the platform device runtime dev_pm_ops warning
    > for now. No point in upsetting users of non-rc kernels.
    >
    > Signed-off-by: Magnus Damm <damm@igel.co.jp>

    Thanks for the patch, I modified the changelog a bit.

    Greg, do you agree with the patch below?

    Rafael

    ---
    From: Magnus Damm <damm@igel.co.jp>
    Subject: PM / Driver Core: Kill dev_pm_ops platform warning for now

    Commit 783ea7d4eeefe895f2731fe73ac951e94418927b
    (Driver Core: Rework platform suspend/resume, print warning)
    added a warning message printed for platform drivers that use the
    legacy PM callbacks rather than struct dev_pm_ops. Unfortunately,
    this resulted in some confusion and made some people try to convert
    drivers by replacing the old callbacks with struct dev_pm_ops in
    automatic way, which generally is not a good idea.

    Remove the platform device runtime dev_pm_ops warning for now,
    because it's annoying to users and it's not really necessary right
    now.

    [rjw: Modified the changelog to be more informative.]

    Signed-off-by: Magnus Damm <damm@igel.co.jp>
    Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    ---
    drivers/base/platform.c | 3 ---
    1 file changed, 3 deletions(-)

    Index: linux-2.6/drivers/base/platform.c
    ===================================================================
    --- linux-2.6.orig/drivers/base/platform.c
    +++ linux-2.6/drivers/base/platform.c
    @@ -483,9 +483,6 @@ int platform_driver_register(struct plat
    drv->driver.remove = platform_drv_remove;
    if (drv->shutdown)
    drv->driver.shutdown = platform_drv_shutdown;
    - if (drv->suspend || drv->resume)
    - pr_warning("Platform driver '%s' needs updating - please use "
    - "dev_pm_ops\n", drv->driver.name);

    return driver_register(&drv->driver);
    }

    \
     
     \ /
      Last update: 2009-08-08 15:19    [W:0.023 / U:242.816 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site