Messages in this thread Patch in this message | | | Date | Fri, 7 Aug 2009 10:27:27 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] perf tools: Fix reading of perf.data file header |
| |
* Brice Goglin <Brice.Goglin@inria.fr> wrote:
> [PATCH] perf stat: change -S for --scale into -c
Applied, thanks Brice!
Find below the full changelog - i filled in the 'why' bits.
Ingo
-------------------------> From d4b2db0a624500c978f14393e6933d5d6aa552d2 Mon Sep 17 00:00:00 2001 From: Brice Goglin <Brice.Goglin@inria.fr> Date: Fri, 7 Aug 2009 10:18:39 +0200 Subject: [PATCH] perf stat: Rename -S/--scale to -c/--scale
We want to use a coherent flag for -S/--stat across all tools, so free up -S in perf stat.
Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: paulus@samba.org LKML-Reference: <4A7BE35F.4060604@inria.fr> Signed-off-by: Ingo Molnar <mingo@elte.hu> --- tools/perf/Documentation/perf-stat.txt | 2 +- tools/perf/builtin-stat.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt index 0d74346..484080d 100644 --- a/tools/perf/Documentation/perf-stat.txt +++ b/tools/perf/Documentation/perf-stat.txt @@ -40,7 +40,7 @@ OPTIONS -a:: system-wide collection --S:: +-c:: scale counter values EXAMPLES diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index f9510ee..b4b06c7 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -496,7 +496,7 @@ static const struct option options[] = { "stat events on existing pid"), OPT_BOOLEAN('a', "all-cpus", &system_wide, "system-wide collection from all CPUs"), - OPT_BOOLEAN('S', "scale", &scale, + OPT_BOOLEAN('c', "scale", &scale, "scale/normalize counters"), OPT_BOOLEAN('v', "verbose", &verbose, "be more verbose (show counter open errors, etc)"),
| |