lkml.org 
[lkml]   [2009]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/6] tracing, page-allocator: Add trace events for anti-fragmentation falling back to other migratetypes

    * Mel Gorman <mel@csn.ul.ie> wrote:

    > +++ b/mm/page_alloc.c
    > @@ -839,6 +839,12 @@ __rmqueue_fallback(struct zone *zone, int order, int start_migratetype)
    > start_migratetype);
    >
    > expand(zone, page, order, current_order, area, migratetype);
    > +
    > + trace_mm_page_alloc_extfrag(page, order, current_order,
    > + start_migratetype, migratetype,
    > + current_order < pageblock_order,
    > + migratetype == start_migratetype);

    This tracepoint too should be optimized some more:

    - pageblock_order can be passed down verbatim instead of the
    'current_order < pageblock_order': it means one comparison less
    in the fast-path, plus it gives more trace information as well.

    - migratetype == start_migratetype check is superfluous as both
    values are already traced. This property can be added to the
    TP_printk() post-processing stage instead, if the pretty-printing
    is desired.

    Ingo


    \
     
     \ /
      Last update: 2009-08-07 10:05    [W:0.020 / U:0.800 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site