lkml.org 
[lkml]   [2009]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] fat: Read buffer overflow
Date
Roel Kluin <roel.kluin@gmail.com> writes:

> If len is less or equal to 0, this results in a read of s[-1].
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
> index 6f27853..114ff6d 100644
> --- a/fs/fat/namei_vfat.c
> +++ b/fs/fat/namei_vfat.c
> @@ -202,6 +202,9 @@ static inline int vfat_is_used_badchars(const wchar_t *s, int len)
> {
> int i;
>
> + if (len <= 0)
> + return -EINVAL;
> +
> for (i = 0; i < len; i++)
> if (vfat_bad_char(s[i]))
> return -EINVAL;

Um..., what case is this possible? vfat_add_entry() checks (len == 0).
And if xlate_to_uni() couldn't convert name, it should return the error.

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>


\
 
 \ /
  Last update: 2009-08-08 01:09    [W:0.044 / U:1.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site